fix: skip error toast for coroutine cancellation#693
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@piotr-iohk this will fix a flackines on a test flow |
Member
Author
|
@piotr-iohk it is still failing |
Collaborator
Yes, looking... |
Collaborator
|
E2e failure: https://github.com/synonymdev/bitkit-android/actions/runs/21206197567/job/61009418465?pr=693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #688
This PR skips showing the error toast when camera initialization fails due to coroutine cancellation.
Description
When navigating away from the SendRecipientScreen while the camera is initializing, a
CancellationExceptionis thrown. This is expected behavior when a coroutine scope leaves composition, but previously it would show an error toast to the user. The fix adds a check to skip the toast forCancellationException.Preview
error-from-e2e.mp4
QA Notes